Allow for non-square logos in Navbar #6901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
At a minimum, there should be max-width set to enforce a reasonable/usable layout |
|
|
@psuet can you please address the |
Some Logos are not "squareable", so they currently look either distorted (without user intervention) or way too small (by manually squaring it) By loosening the width restriction, most logos, square or rectangular, will not be distorted and scaled automatically.
|
Hi @psuet if you can fix the conflicts here I'm happy to merge this in, don't want it sitting here forever :) |
|
This PR seems stale. Please react to show this is still important. |
|
@psuet can you please address the conflicts here? |
SchrodingersGat
added a commit
to SchrodingersGat/InvenTree
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Logos are not "squareable", so they currently look either distorted (without user intervention) or way too small (by manually squaring it)
By loosening the width restriction, most logos, square or rectangular (max ratio 2:1), will not be distorted and scaled automatically.