-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Make actions recognisable #8005
[PUI] Make actions recognisable #8005
Conversation
…pui-make-actions-recognisable
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8005 +/- ##
==========================================
+ Coverage 83.57% 83.63% +0.05%
==========================================
Files 1140 1141 +1
Lines 50874 50878 +4
Branches 1774 1783 +9
==========================================
+ Hits 42520 42552 +32
+ Misses 7913 7882 -31
- Partials 441 444 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I like the suggestion from @SchrodingersGat |
That's pretty clean IMO |
I think now its really hard to tell, which "down caret" belongs to what action, maybe an outline would help to add some separation, but not sure how that will look like. |
That's true. Maybe its just me having problems to see the separation. |
What about a mantine indicator with the caret attached directly to the button |
Light with chevrons is my pick :) And maybe we add the chevron to the vertical dot menu too? |
Ok then this is ready for merge - light with chevron is the current state of the PR.
I would not add chevrons to the dot menu, I think that 3 dots are universally understood as "more" - that is why I suggested usage of them in the first place. |
In this case, should we add a special dropdown menu just for the "more" actions - I see that you have added a lot of instances of |
Sure, I can look into that. |
@SchrodingersGat I have added a special dropdown to adress this |
@SchrodingersGat this is ready for review and merge |
Nice work, thanks for this! |
Action Dropdowns are not very recognisable right now. Therefore, I propose adding indicators similar to the screenshots below to buttons with more than 1 action. I am not sure how to style that, below solution is not the final goal - maybe a single indicator could be enough for example.
Current
Proposed
Fixes invenhost#98