Add extra undefined check for table filters #8008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchrodingersGat
added
bug
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8008 +/- ##
==========================================
+ Coverage 83.57% 83.68% +0.10%
==========================================
Files 1140 1141 +1
Lines 50874 50860 -14
Branches 1774 1775 +1
==========================================
+ Hits 42520 42562 +42
+ Misses 7913 7847 -66
- Partials 441 451 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matmair
approved these changes
Aug 27, 2024
- Do not return early, this is mistake! - Correctly handle empty activeFilter state
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Add extra undefined check for table filters * Logic fix.. - Do not return early, this is mistake! - Correctly handle empty activeFilter state (cherry picked from commit 7d844e0)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
added a commit
that referenced
this pull request
Aug 27, 2024
* Add extra undefined check for table filters * Logic fix.. - Do not return early, this is mistake! - Correctly handle empty activeFilter state (cherry picked from commit 7d844e0) Co-authored-by: Oliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug which sometimes causes rendering error for PUI table