Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check plugin registry hash when registering events #8023

Closed

Conversation

SchrodingersGat
Copy link
Member

  • Before registering events, check plugin registry for reload
  • Ensures that background worker plugin registry is up-to-date

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed plugin Plugin ecosystem backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x labels Aug 28, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 28, 2024
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit d4e6418
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66cebcb995579c0008d33b20
😎 Deploy Preview https://deploy-preview-8023--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat
Copy link
Member Author

Closing, I missed that check_reload is called a few lines later. My problem was actually in my plugin code...

@SchrodingersGat SchrodingersGat deleted the plugin-reload branch August 28, 2024 06:02
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (93e06a0) to head (d4e6418).
Report is 293 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8023   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files        1141     1141           
  Lines       50860    50861    +1     
  Branches     1775     1775           
=======================================
+ Hits        42561    42563    +2     
+ Misses       7840     7839    -1     
  Partials      459      459           
Flag Coverage Δ
backend 85.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed plugin Plugin ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant