Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barcode logging #8150

Merged
merged 47 commits into from
Sep 23, 2024
Merged

Barcode logging #8150

merged 47 commits into from
Sep 23, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Sep 20, 2024

Why / What / Huh?

TODO

  • Implement for other barcode endpoints
  • Unit testing
  • Playwright testing
  • Documentation

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature old user interface Issues with Old User interface barcode Barcode scanning and integration Platform UI Related to the React based User Interface labels Sep 20, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 40b0edd
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66f164aaa4da0c0008b5c086
😎 Deploy Preview https://deploy-preview-8150--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 74.89540% with 60 lines in your changes missing coverage. Please review.

Project coverage is 84.21%. Comparing base (4892410) to head (40b0edd).
Report is 312 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/plugin/base/barcodes/api.py 70.86% 37 Missing ⚠️
...nd/src/tables/settings/BarcodeScanHistoryTable.tsx 60.97% 16 Missing ⚠️
src/frontend/src/tables/settings/ErrorTable.tsx 0.00% 5 Missing ⚠️
src/frontend/src/components/nav/PanelGroup.tsx 0.00% 0 Missing and 1 partial ⚠️
src/frontend/src/functions/tables.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8150      +/-   ##
==========================================
- Coverage   84.22%   84.21%   -0.01%     
==========================================
  Files        1149     1153       +4     
  Lines       51546    51755     +209     
  Branches     1815     1832      +17     
==========================================
+ Hits        43414    43588     +174     
- Misses       7923     7959      +36     
+ Partials      209      208       -1     
Flag Coverage Δ
backend 85.78% <78.73%> (-0.01%) ⬇️
pui 67.61% <64.61%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchrodingersGat SchrodingersGat changed the title WIP: Barcode log Barcode logging Sep 20, 2024
@SchrodingersGat SchrodingersGat merged commit 6002103 into inventree:master Sep 23, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the barcode-log branch September 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barcode Barcode scanning and integration enhancement This is an suggested enhancement or new feature old user interface Issues with Old User interface Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants