[WIP] Build line filter fix #8343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expensive to have a "many" serializer automatically used - Adjust existing tables accordingly - Fetch on demand
SchrodingersGat
added
bug
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8343 +/- ##
==========================================
- Coverage 84.30% 84.07% -0.23%
==========================================
Files 1166 1166
Lines 52980 53399 +419
Branches 1946 1938 -8
==========================================
+ Hits 44663 44894 +231
- Misses 7836 8027 +191
+ Partials 481 478 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Multi-level annotation proves to be very expensive - Reduce complexity, save a bunch of time on queries - Remove 'total_allocated_stock' field - Adjust API query filter
…venTree into build-line-filter-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking down some issues with filtering of BuildLine objects via API
Changes
The major change here has been to optimize and simplify the queryset annotations. The generated SQL was getting out of hand - it may have simply been "too complex"?
For a sample dataset I have got the query time down from ~10 seconds to ~500ms (for the same data).
Observations
Using the postgresql backend, the
build.test_api.BuildLineTests.test_filter_availablemethod takes > 20 seconds to run. It takes under 1 second with sqlite backend. Not sure what is going on there, even after extended testing.Strangely the same API calls are now quite "efficient" in actual operation (i.e. not in test mode) - even with postgresql backend.