Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup modals #8432

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

  • Tweaks / improvements for system information modals

@SchrodingersGat SchrodingersGat added user interface refactor Platform UI Related to the React based User Interface labels Nov 5, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 54a321a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/672b305f8990070008f63fb6
😎 Deploy Preview https://deploy-preview-8432--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (e46ae1a) to head (54a321a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/frontend/src/components/modals/LicenseModal.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8432   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files        1170     1170           
  Lines       53463    53468    +5     
  Branches     2004     2005    +1     
=======================================
+ Hits        45103    45108    +5     
- Misses       7846     7855    +9     
+ Partials      514      505    -9     
Flag Coverage Δ
pui 67.91% <87.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit c062d5e into inventree:master Nov 6, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-cleanup branch November 6, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants