Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded AjaxView usage #8461

Merged
merged 7 commits into from
Nov 10, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Nov 10, 2024

This PR removes an unneeded dependency on AjaxView in prep for #8384. Also updates the schema for the information endpoint and removes the general "not found" endpoint from the schema.

@matmair matmair self-assigned this Nov 10, 2024
@matmair matmair added this to the 0.17.0 milestone Nov 10, 2024
Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 93ef393
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67312b5f6011c4000833945b

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.36%. Comparing base (255a5d0) to head (93ef393).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8461   +/-   ##
=======================================
  Coverage   84.35%   84.36%           
=======================================
  Files        1175     1175           
  Lines       53636    53662   +26     
  Branches     2015     2015           
=======================================
+ Hits        45245    45270   +25     
- Misses       7872     7873    +1     
  Partials      519      519           
Flag Coverage Δ
backend 85.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair added the api Relates to the API label Nov 10, 2024
@SchrodingersGat SchrodingersGat merged commit 9cd0394 into inventree:master Nov 10, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the remove-ajax-refs branch November 10, 2024 22:11
@SchrodingersGat
Copy link
Member

Nice addition, thanks @matmair

@matmair
Copy link
Member Author

matmair commented Nov 10, 2024

@SchrodingersGat slowly chipping away at CUI removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants