Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various sonarlint warnings #8479

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Nov 12, 2024

No description provided.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit c081f0a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67358b54c0560e00087c85a6
😎 Deploy Preview https://deploy-preview-8479--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (9d8f874) to head (c081f0a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nd/src/tables/settings/BarcodeScanHistoryTable.tsx 14.28% 6 Missing ⚠️
...c/frontend/src/components/plugins/PluginDrawer.tsx 0.00% 4 Missing ⚠️
...frontend/src/components/nav/NotificationDrawer.tsx 0.00% 1 Missing ⚠️
...end/src/components/plugins/PluginSettingsPanel.tsx 0.00% 1 Missing ⚠️
...rontend/src/components/plugins/RemoteComponent.tsx 50.00% 0 Missing and 1 partial ⚠️
src/frontend/src/tables/settings/ErrorTable.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8479      +/-   ##
==========================================
+ Coverage   84.31%   84.34%   +0.02%     
==========================================
  Files        1178     1178              
  Lines       53731    53690      -41     
  Branches     2022     2022              
==========================================
- Hits        45305    45284      -21     
+ Misses       7916     7896      -20     
  Partials      510      510              
Flag Coverage Δ
pui 68.63% <65.85%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit ee01ac5 into inventree:master Nov 14, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the fix-readonly branch November 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants