Remove custom context processors #8540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only merge after 0.17.0 release - Remove code which injects custom context variables into CUI requests - Not needed for new API-based PUI code - Speeds up requests - remove unnecessary DB hits
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matmair
approved these changes
Nov 24, 2024
|
See also #8384 |
matmair
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8540 +/- ##
==========================================
- Coverage 85.26% 75.77% -9.49%
==========================================
Files 1174 1193 +19
Lines 52506 63969 +11463
Branches 2072 2026 -46
==========================================
+ Hits 44767 48472 +3705
- Misses 7232 14974 +7742
- Partials 507 523 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matmair
changed the title
|
@SchrodingersGat does this mean we can lower the general DB hit limit? |
Maybe - i'm not exactly sure how many database hits we are saving here |
- No longer needed as CUI is gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL 0.17.0 IS RELEASED