Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.17.x] Fix REST registration endpoint (#8738) #8763

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Dec 24, 2024

Backport

This will backport the following commits from master to 0.17.x:

Questions ?

Please refer to the Backport tool documentation

* Re-add html account base
Fixes inventree#8690

* fix base template

* override dj-rest-auth pattern to fix fixed token model reference

* pin req

* fix urls.py

* move definition out to separate file

* fix possible issues where email is not enabled but UI shows that registration is enabled

* fix import order

* fix token recovery

* make sure registration redirects

* fix name change

* fix import name

* adjust description

* cleanup

* bum api version

* add test for registration

* add test for registration requirements
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (3cb806d) to head (06a3fd0).
Report is 1 commits behind head on 0.17.x.

Files with missing lines Patch % Lines
...backend/InvenTree/InvenTree/auth_override_views.py 71.42% 4 Missing ⚠️
...ontend/src/components/forms/AuthenticationForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           0.17.x    #8763      +/-   ##
==========================================
- Coverage   84.59%   84.58%   -0.01%     
==========================================
  Files        1199     1201       +2     
  Lines       54549    54678     +129     
  Branches     2087     2087              
==========================================
+ Hits        46143    46250     +107     
- Misses       7901     7921      +20     
- Partials      505      507       +2     
Flag Coverage Δ
backend 86.13% <92.45%> (+0.09%) ⬆️
pui 69.23% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 40245a6 into inventree:0.17.x Dec 25, 2024
21 checks passed
@SchrodingersGat SchrodingersGat deleted the backport/0.17.x/pr-8738 branch December 25, 2024 00:38
@SchrodingersGat SchrodingersGat added this to the 0.17.1 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants