Fix default value for SESSION_COOKIE_SECURE #8767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default value was previously 'True' - Documentation indicated that it was 'False' - Value in config_template.yaml was 'False' (but commented out)
SchrodingersGat
added
bug
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8767 +/- ##
=======================================
Coverage 85.20% 85.20%
=======================================
Files 1172 1172
Lines 51538 51538
Branches 2089 2089
=======================================
+ Hits 43911 43912 +1
+ Misses 7118 7117 -1
Partials 509 509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 26, 2024
- Default value was previously 'True' - Documentation indicated that it was 'False' - Value in config_template.yaml was 'False' (but commented out) (cherry picked from commit d4ee8c5)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
added a commit
that referenced
this pull request
Dec 26, 2024
- Default value was previously 'True' - Documentation indicated that it was 'False' - Value in config_template.yaml was 'False' (but commented out) (cherry picked from commit d4ee8c5) Co-authored-by: Oliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrueFalseFalse(but commented out)