Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Set password #8770

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat added the security Relates to a security issue label Dec 26, 2024
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 26, 2024
Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 334570e
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/676ddfe98f95420008df174c
😎 Deploy Preview https://deploy-preview-8770--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (ae7f4e3) to head (334570e).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/pages/Auth/ChangePassword.tsx 72.22% 3 Missing and 2 partials ⚠️
src/frontend/src/router.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8770   +/-   ##
=======================================
  Coverage   85.27%   85.28%           
=======================================
  Files        1172     1173    +1     
  Lines       51541    51613   +72     
  Branches     2090     2094    +4     
=======================================
+ Hits        43953    44016   +63     
- Misses       7065     7075   +10     
+ Partials      523      522    -1     
Flag Coverage Δ
backend 86.94% <ø> (-0.04%) ⬇️
pui 69.46% <76.92%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
Would probably be good to add a test that this works to ensure things like #6293 do not break the end to end interaction.

@SchrodingersGat
Copy link
Member Author

@matmair testing added :)

@SchrodingersGat SchrodingersGat merged commit 189f230 into inventree:master Dec 27, 2024
27 checks passed
@SchrodingersGat SchrodingersGat deleted the set-password branch December 27, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Relates to a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't set any password
2 participants