Bug fix for list filtering (#566)

- Observe "tristate" values
inventree · Dec 6, 2024 · 5dab11e · 5dab11e
1 parent 707d251
commit 5dab11e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/assets/release_notes.md b/assets/release_notes.md
@@ -9,6 +9,8 @@
 - Provide "upload image" shortcut on Purchase Order detail view
 - Provide "upload image" shortcut on Sales Order detail view
 - Clearly indicate if a StockItem is unavailable
+- Improved list filtering management
+- Updated translations
 
 ### 0.16.5 - September 2024
 ---

diff --git a/lib/widget/paginator.dart b/lib/widget/paginator.dart
@@ -50,7 +50,9 @@ abstract class PaginatedSearchState<T extends PaginatedSearchWidget> extends Sta
     key = "${prefix}filter_${key}";
 
     Map<String, dynamic> opts = filterOptions[key] ?? {};
-    dynamic backup = opts["default"];
+
+    bool tristate = (opts["tristate"] ?? true) as bool;
+    dynamic backup = tristate ? null : opts["default"];
     final result = await InvenTreeSettingsManager().getValue(key, backup);
 
     return result;
@@ -59,7 +61,12 @@ abstract class PaginatedSearchState<T extends PaginatedSearchWidget> extends Sta
   // Set the boolean value of a particular boolean filter
   Future<void> setFilterValue(String key, dynamic value) async {
     key = "${prefix}filter_${key}";
-    await InvenTreeSettingsManager().setValue(key, value);
+
+    if (value == null) {
+      await InvenTreeSettingsManager().removeValue(key);
+    } else {
+      await InvenTreeSettingsManager().setValue(key, value);
+    }
   }
 
   // Construct the boolean filter options for this list