Fix messaging errors (#43)

fixes #22
invertase · Jul 15, 2024 · dd8ef56 · dd8ef56
1 parent 85c3680
commit dd8ef56
Show file tree

Hide file tree

Showing 13 changed files with 988 additions and 780 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -44,7 +44,7 @@ jobs:
         run: dart analyze
 
       - name: Run tests
-        run: ${{github.workspace}}/scripts/coverage.sh
+        run: firebase emulators:exec --project dart-firebase-admin --only auth,firestore "dart test"
 
       - name: Upload coverage to codecov
         run: curl -s https://codecov.io/bash | bash
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -6,6 +6,7 @@
     "Millis",
     "OIDC",
     "pbkdf",
+    "responsetype",
     "rrggbb",
     "rrggbbaa",
     "SIGNIN",

diff --git a/packages/dart_firebase_admin/CHANGELOG.md b/packages/dart_firebase_admin/CHANGELOG.md
@@ -1,5 +1,8 @@
-## Unreleased fix
+## Unreleased minor
 
+- Fixes some errors incorrectly coming back as "unknown".
+- Renamed various error codes to remove duplicates and removed
+  unused codes.
 - Fixes crash when updating users (thanks to @HeySreelal)
 - Marked various classes that cannot be extended as base/final.
 

diff --git a/packages/dart_firebase_admin/lib/src/app/firebase_admin.dart b/packages/dart_firebase_admin/lib/src/app/firebase_admin.dart
@@ -1,7 +1,11 @@
 part of '../app.dart';
 
 class FirebaseAdminApp {
-  FirebaseAdminApp.initializeApp(this.projectId, this.credential);
+  FirebaseAdminApp.initializeApp(
+    this.projectId,
+    this.credential, {
+    Client? client,
+  }) : _clientOverride = client;
 
   /// The ID of the Google Cloud project associated with the app.
   final String projectId;
@@ -31,8 +35,13 @@ class FirebaseAdminApp {
       auth3.IdentityToolkitApi.firebaseScope,
     ],
   );
+  final Client? _clientOverride;
 
   Future<Client> _getClient(List<String> scopes) async {
+    if (_clientOverride != null) {
+      return _clientOverride;
+    }
+
     if (isUsingEmulator) {
       return _EmulatorClient(Client());
     }