Fix Auth.verifyIdToken() #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finish implementing the token verification using the updated dart_jsonwebtoken library
|
|
This was referenced Oct 9, 2024
rrousselGit
reviewed
Oct 10, 2024
| } | ||
| } | ||
|
|
||
| sealed class SecretOrPublicKey {} | ||
|
|
||
| @internal | ||
| Future<void> verifyJwtSignature( | ||
| void verifyJwtSignature( |
rrousselGit
reviewed
Oct 10, 2024
| group('PublicKeySignatureVerifier', () { | ||
| final privateKey = RSAPrivateKey(''' | ||
| -----BEGIN PRIVATE KEY----- | ||
| MIIEvwIBADANBgkqhkiG9w0BAQEFAASCBKkwggSlAgEAAoIBAQC7VJTUt9Us8cKj |
There was a problem hiding this comment.
It's the one used in dart_jsonwebtoken's own tests.
rrousselGit
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish implementing the token verification using the updated dart_jsonwebtoken library
This is inspired from #48 but uses the verifyJwtSignature function.
Related Issues
fixes #20 #33
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).I have updated the
CHANGELOG.mdof the relevant packages.Changelog files must be edited under the form:
If this contains new features or behavior changes,
I have updated the documentation to match those changes.