Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Page with TS codeblocks causes Internal Server Error #364

Closed
DoctorJohn opened this issue Sep 6, 2024 · 1 comment
Closed

bug: Page with TS codeblocks causes Internal Server Error #364

DoctorJohn opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@DoctorJohn
Copy link

Starting a few days a go one of the react-native-google-mobile-ads pages started showing the following error message:

image

The page used to work flawlessly before, so I assume this has something to do with #359. Checking the browsers dev tools reveals that the GET request to https://docs.page/invertase/react-native-google-mobile-ads/impression-level-ad-revenue results in an internal server error (status 500).

I narrowed the problem down to the following two codeblocks in our docs:

https://github.com/invertase/react-native-google-mobile-ads/blob/b4443b473bba2322b8b7f0b80ed9cd7689af8f0a/docs/impression-level-ad-revenue.mdx?plain=1#L26-L39

Removing them OR(!) switching their language from ts to tsx resolved the problem, which can be verified by looking at the preview of the branch I used for debugging.

@Salakar Salakar added the bug Something isn't working label Sep 7, 2024
@Salakar Salakar changed the title Page with TS codeblocks causes Internal Server Error bug: Page with TS codeblocks causes Internal Server Error Sep 7, 2024
@Ehesp
Copy link
Member

Ehesp commented Sep 9, 2024

@DoctorJohn Thanks for reporting. This was because of the twoslash rendering which has now been removed. Unfortunately it can't handle external types without them being explicitly installed which won't work for docs.page.

The page is live again.

@Ehesp Ehesp closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants