Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: work around issue with docs.page codeblocks #637

Closed
wants to merge 1 commit into from

Conversation

DoctorJohn
Copy link
Contributor

Description

Our docs for impression-level ad revenue are currently down. They used to work perfectly but stopped working a few days ago. I suspect the recent major docs.page update.

The page currently returns status 500. Through trial and error, I narrowed the issue down to the two code blocks on that page. The page fails to render when the codeblocks use ts as their language. Curiously enough, changing the language to tsx resolves the issue.

I just reported the issue upstream: invertase/docs.page#364
If we don't want to wait for it to get addressed, we can switch the affected code blocks to tsx.

Test Plan

  • Checked the docs.page preview for the updated docs

Copy link

docs-page bot commented Sep 6, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~637

Documentation is deployed and generated using docs.page.

@dylancom
Copy link
Collaborator

dylancom commented Sep 9, 2024

The page seems to be working fine again.

@dylancom dylancom closed this Sep 9, 2024
@DoctorJohn DoctorJohn deleted the fix-docs-page branch September 9, 2024 13:32
@DoctorJohn
Copy link
Contributor Author

The page seems to be working fine again.

Correct, the issue has been resolved upstream. No need for the work around anymore 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants