feat: install command #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Lyokone
had a problem deploying
to
CI Environment
GitHub Actions
Failure
russellwheatley
requested changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM for the most part 💪 . I do think we should have some integration tests for unhappy paths and happy paths 😄. But I guess that would be tricky with inputs required for selecting plugins. Maybe we should have a flag for simply installing the packages that are in the pubspec so they don't have to input additional packages? 🤔 If that isn't desirable for the user, we could have one simply for the CI so we can test.
Lyokone
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Lyokone
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Lyokone
had a problem deploying
to
CI Environment
GitHub Actions
Failure
TarekkMA
approved these changes
May 7, 2024
russellwheatley
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore