Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging, ios): clarify that some simulators may get FCM messages now #7381

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

Attempting to clarify that modern simulators on modern macs may actually get APNs tokens and receive messages now. This was confusing before as the feature was announced earlier as part of breaking changes in react-native-firebase v17 but there was still some documentation around stating exactly the opposite

Related issues

#6893

Release Summary

docs, no release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Just docs, but if there was a typo or something, CI will find it...


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Sep 28, 2023
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 0:14am
react-native-firebase-next ❌ Failed (Inspect) Oct 11, 2023 0:14am

@mikehardy mikehardy force-pushed the @mikehardy/simulator-fcm-docs branch from 151c212 to b3eed08 Compare October 10, 2023 23:54
@mikehardy mikehardy merged commit 305d38b into main Oct 11, 2023
10 checks passed
@mikehardy mikehardy deleted the @mikehardy/simulator-fcm-docs branch October 11, 2023 03:17
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant