Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth): Link Multiple Auth Providers to a Firebase Account #7479

Merged
merged 3 commits into from
Nov 28, 2023
Merged

docs(auth): Link Multiple Auth Providers to a Firebase Account #7479

merged 3 commits into from
Nov 28, 2023

Conversation

Milutin-P
Copy link
Contributor

Description

In the latest PR#7443 I noticed that we deleted a section in the docs. So, I've rewritten and returned that deleted section. I've also added quote from the docs for people to understand when they need to use it.

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • This is a breaking change;
    • No

🔥

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 5:51pm
react-native-firebase-next ❌ Failed (Inspect) Nov 28, 2023 5:51pm

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks so much. Our linters and formatters always have a lot to say about big blobs of documentation but that's trivial for me to shepherd through to merge once the text actually exists (as it does now...)

So I'll fix any little spelling or linter stuff and get this in

@mikehardy
Copy link
Collaborator

Ah - except it looks like you've already done so 😆 . Most excellent

@mikehardy mikehardy merged commit 918f0dd into invertase:main Nov 28, 2023
8 checks passed
@Milutin-P Milutin-P deleted the patch-1 branch November 28, 2023 18:23
@Milutin-P
Copy link
Contributor Author

Ah - except it looks like you've already done so 😆 . Most excellent

I have reviewed several pull requests that you have approved. By doing that, I've identified specific details on which you focus on and commonly fix in all of them.

slika

Thank you again for your dedication to this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants