Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): add notification service extension target for image support in notifications #8191

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emirmuminoglu
Copy link

@emirmuminoglu emirmuminoglu commented Dec 15, 2024

Description

It was impossible to add image support in notifications on iOS. I added the notification service extension to the expo plugin of messaging package. The code might have issues with style and convention. I didn't have the chance to read the other packages and code of conduct. Also I didn't updated tests and docs. So it's not ready to merge but it functions correctly. I use this code in my project with patch-package so even it's not merged it can help someone maybe.

If you give feedback and address the issues with the pull request, I would be happy to contribute to the pull request until it's merged.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

🔥

Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 3:41pm

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants