-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(analytics): deprecation warnings for v8 API ahead of future major release #8197
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mikehardy - Started this and I wanted to get your thoughts on the modular event methods we've ported over. The firebase-js-sdk doesn't have methods for every event, they just have Wondering whether we should deprecate all the modular methods we've ported over and just use Part of me thinks they're useful but another part thinks we should stick to firebase-js-sdk API 🤔 |
@russellwheatley Deviating from firebase-js-sdk API is a slippery slope and at least personally I can only justify it when there is a native method that's really useful and has no analog we can do with firebase-js-sdk - |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
49552e6
to
b21ad22
Compare
ac79ae1
to
b80a247
Compare
b80a247
to
13011c3
Compare
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter