Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adopt firebase-ios-sdk 11.7.0 / firebase-android-sdk 33.7.0 #8232

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: adopt firebase-ios-sdk 11.7.0 / firebase-android-sdk 33.7.0 #8232

merged 2 commits into from
Jan 16, 2025
+6 −6

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Jan 16, 2025 •
edited
Loading

Description

Standard SDK updates for the native SDKs, if CI passes I'll assume they're good

I haven't seen problems with them as I build test them in make-demo.sh anyway

Related issues

This may fix user-reported StoreKit2 in-app-purchase logging discussed here:

Additionally this switches our apple CI to use macos-15-xlarge vs previous macos-14-xlarge to avoid a toolchain installation issue on the macos-14 runners:

Release Summary

single conventional commit all ready for rebase + release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

local build testing looked good

CI will chew on it and render a verdict

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jan 16, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 7:12pm

@mikehardy mikehardy mentioned this pull request Jan 16, 2025
Open
@mikehardy
test(ci): switch to macos-15 runners to avoid iOS SDK 18.2 issue
4d9e87d 
it appears the macos-14 runners have a simulator definition issue,
which breaks our tests on macos-14. macos-15 apparently does not
suffer the same, and is the future anyway. switch now
@mikehardy mikehardy merged commit a8fe167 into main Jan 16, 2025
20 checks passed
@mikehardy mikehardy deleted the @mikehardy/sdk-update branch January 16, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Workflow: Pending Merge Waiting on CI or similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikehardy