Fixing npm install on Windows #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 13, 2017 12:40
Conflicts: lib/Compiler.js
|
I think the problem here is you're creating a pull request on your fork's Basically, working with a "feature branch" mentality is your friend. ;) |
|
I think I understand what happened. I was also confused about my first pull request which I intended only to include the simple UTF-8 fix but actually included all the Compiler.ts changes. |
|
This got fixed separately at 69a7e72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why 11 commits that it seemed like you already merged in are listed here, but apparently they don't change anything? Idk, pull requests, yikes