Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better fix for Windows tsc build error, Can specify output dir from cLI #25

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Better fix for Windows tsc build error, Can specify output dir from cLI #25

merged 2 commits into from
Nov 10, 2017

Conversation

NQNStudios
Copy link
Collaborator

Addresses issue #21, #12

Changes proposed by this pull request:

  • Ignore every exit code of tsc except for 1
  • Remove examples/basic/index.html from the repo because it's a generated file
  • user can specify where to put the compiler's output (default dist)
  • build all examples into their own dist folders

@invicticide to review

@invicticide invicticide mentioned this pull request Nov 10, 2017
Closed
@invicticide invicticide merged commit 4d1ed9f into invicticide:dev Nov 10, 2017
invicticide pushed a commit that referenced this pull request Nov 10, 2017
Merge PR #25 with my fix for unbundled scripts deployment
df270da 
- Copy unbundled scripts to the output path
- Don't ignore examples/basic/dist/** as it's useful to check any diffs on the output as the compiler changes, as a kinda-sorta unit test
@NQNStudios NQNStudios deleted the output-dir branch November 12, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NQNStudios @invicticide