-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browserify as a core component of Fractive #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR that will probably precipitate a lot more structural shifts towards an architecture more rooted in current best practices for web dev.
Pros:
require()
.Core
at runtime, which opens up a lot of possibilities for expanding the library without bloating our own codebase with cruft we'll have to maintain later.Cons
window.globalVar
instead ofvar globalVar
orglobalVar
, and functions must be declared aswindow.Function = function()
in order for globals to be accessible to Core. I will argue this is worth the cost because var declarations are meant to be local, not global, and previously we weren't respecting this. Also, assignment to undeclared variables (i.e. the creation of implicit globals) is considered by some to be bad practice and underuse strict
syntax, forbidden. So this change merely enforces what would be thought of best practices for JavaScript, and prevents unintended global variable errors.So I can see why this might go against some of the design principles you set out with, but so far it's working well for me and it will be the basis for a lot of my future enhancements to SpaceFractive, so I'd hope it can be accepted and I'll be able to keep contributing back to the upstream.
@invicticide to review