Skip to content

Commit

Permalink
Rename job helm test job resources to avoid downstream duplication (#115
Browse files Browse the repository at this point in the history
)

Downstream php harness uses these as static templates rather than
dynamic job configuration, so results in an error during the pvc test
when same name resources.

dynamic jobs don't include the name of the service they were in, whether
that was a right decision or not.
  • Loading branch information
andytson-inviqa authored Sep 20, 2023
1 parent 6c8f547 commit d0979c8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions helm/app/tests/values-jobs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
some-jobs:
enabled: true
jobs:
app-init:
example-app-init:
annotations:
helm.sh/hook: "pre-install"
helm.sh/hook-delete-policy: "before-hook-creation"
Expand All @@ -16,7 +16,7 @@ services:
command:
- app
- init
app-migrate:
example-app-migrate:
annotations:
helm.sh/hook: "pre-upgrade"
helm.sh/hook-delete-policy: "before-hook-creation"
Expand Down

0 comments on commit d0979c8

Please sign in to comment.