-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sum_amount_ support to table plugin #179
base: master
Are you sure you want to change the base?
Conversation
Since it's your first PR, you should go all the way and add a test case and a sample invoice. I'm having a hard time imagining how this works or when. Without a test case and test PDF, the feature may be broken by someone else in the future. One more reason to add one. (any confidential content can be redacted or replaced in the PDF) |
@m3nu what do you think about refactoring to separate field extraction from type conversion and sum field aggregation? The tables plugin is a new way to extract fields but duplicates the type conversion code from the core lib. If the core lib handled those two tasks as the final step before output, the plugins could take advantage of it. That would simplify the plugins and solve this issue in a cleaner way. |
Any special handling of extracted data based on fields names is not a really good idea. It's not flexible enough. It doesn't allow specifying all details on how data should be handled. For the same reason new syntax for If we need feature as proposed in this pull request we should probably think about syntax like
|
I agree with @rmilecki on the syntax. |
No description provided.