Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Adding Maximum Clients Validation Message On Client Create Modal #2321

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

Civolilah
Copy link
Collaborator

@Civolilah Civolilah commented Jan 21, 2025

@beganovich @turbo124 The PR includes adding a validation message for maximum clients if it is returned from the API under the "Name" client field. Screenshot:

Screenshot 2025-01-22 at 00 08 26

Let me know your thoughts.

@Civolilah
Copy link
Collaborator Author

@turbo124 I remember that we worked on improving the clients limit message a few months ago. We added additional explanatory text with a link alongside the message that is returned from the API. However, it looks like we missed the translation keyword for the additional text we wanted to add there. Screenshot:

Screenshot 2025-01-22 at 00 10 27

The clients_limit translation keyword is missing.

@turbo124
Copy link
Member

Does this cover the modal (when creating a client from the invoice itself?)

@beganovich beganovich merged commit 43e6dcb into invoiceninja:develop Jan 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants