Configure and model install TUI tweaks #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipsterusername
approved these changes
Jun 8, 2023
|
A most elegant solution. |
|
Should this be rolled into #3547 , or merged separately following that? |
This should be merged separately. Either one can be merged first and I will resolve any conflicts before merging the second. |
ebr
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Tested by merging with #3547 locally (to work around 'model type "main"' errors)
[2023-06-26 16:00:49,153]::[InvokeAI]::ERROR --> Insufficient horizontal space for the interface. Please make your window wider and try again.
- works 👍 as expected on Gnome terminal.
- still line wrapping (also as expected) on 3rd party terminals that do not respond to being resized programmatically.
- But , this PR fixes the crash when 3rd party terminals (e.g. Terminator) are resized to fixe the line wrapping - the above message is printed instead.
All works great from my perspective!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer TUI requires a minimum window width and height to provide a satisfactory user experience. If, after trying and exhausting all means of enlarging the window (on Linux, Mac and Windows) the window is still too small, this PR generates a message telling the user to enlarge the window and pausing until they do so. If the user fails to enlarge the window the program will proceed, and either issue an error message that it can't continue (on Windows), or show a clipped display that the user can remedy by enlarging the window.