image boards #3534
image boards #3534
Conversation
psychedelicious
force-pushed
the
feat/api/image-boards
branch
from
40f320e
to
6601cee
Compare
|
I've rebased this on #3537 |
psychedelicious
force-pushed
the
feat/api/image-boards
branch
from
2173561
to
d97555c
Compare
we can extend this to many-to-many in the future if desired.
UI should only work w/ BoardDTO
To determine whether the Load More button should work, we need to keep track of how many images are left to load for a given board or category. The Assets tab doesn't work, though. Need to figure out a better way to handle this.
psychedelicious
requested review from
psychedelicious,
blessedcoolant and
Kyle0654
as code owners
|
I forgot to add a way to remove an image from a board, but I'd like to get the merged and then continue to iterate. |
There was a problem hiding this comment.
A few things aren't working for me locally:
- add board - I can't see the new board until I refresh. this seems to only happen when i am going from 0 to 1 boards 🤔 was able to reproduce reliably by deleting all boards and then adding one
- deleting a board that had images on it causes them to be in a bad state where they can't be added to other boards (maybe need a cascade delete on board delete?) (this may have actually been left over from my previous state a few days ago bc it seems to work fine on fresh DB)
- (probably unrelated?) saving selection of canvas image to gallery is not honoring selection again
Had incorrect `invalidatesTags` array for the mutation.
Fixed
Can't recreate this
Also cannot recreate this, if I enable |
|
@maryhipp I've added the ability to remove images from boards (in the context menu). I'd like to merge if you're happy, and then in a later PR, do a sweep of the board related services and their methods - I think there is room for cleanup. But the hard-to-change part (the db) is good I believe. |
No description provided.