Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove manual offload from Depth Anything Processor #5812

Merged
merged 2 commits into from
Mar 1, 2024
Merged

cleanup: Remove manual offload from Depth Anything Processor #5812

merged 2 commits into from
Mar 1, 2024

Conversation

blessedcoolant
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

@github-actions github-actions bot added documentation Improvements or additions to documentation api python PRs that change python files Root PythonDeps invocations PRs that change invocations backend PRs that change backend files services PRs that change app services frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files CICD labels Feb 27, 2024
@blessedcoolant blessedcoolant changed the base branch from main to next February 27, 2024 15:00
@blessedcoolant blessedcoolant force-pushed the remove-da-offload branch 2 times, most recently from 54d6b6f to 5c22bfb Compare February 27, 2024 15:22
@hipsterusername
Copy link
Member

@blessedcoolant Is update to use MM to do this still an open/pending one?

@blessedcoolant
Copy link
Collaborator Author

Open. That probably better handled by @lstein or someone who is more familiar with the MM code.

@blessedcoolant blessedcoolant merged commit 80fd3d3 into invoke-ai:next Mar 1, 2024
7 of 8 checks passed
@blessedcoolant blessedcoolant deleted the remove-da-offload branch March 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious Awaiting requested review from psychedelicious psychedelicious is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@ebr ebr Awaiting requested review from ebr

@GreggHelt2 GreggHelt2 Awaiting requested review from GreggHelt2

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@RyanJDick RyanJDick Awaiting requested review from RyanJDick RyanJDick is a code owner

Assignees
No one assigned
Labels
api backend PRs that change backend files CICD documentation Improvements or additions to documentation frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies invocations PRs that change invocations python PRs that change python files Root services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blessedcoolant @hipsterusername