Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next: Fix TI Loading for sdxl prompt #5814

Closed
wants to merge 2 commits into from
Closed

Next: Fix TI Loading for sdxl prompt #5814

wants to merge 2 commits into from

Conversation

brandonrising
Copy link
Collaborator

@brandonrising brandonrising commented Feb 27, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

Currently the SDXLPromptInvocationBase reads TI triggers from the prompt as names instead of keys.

@github-actions github-actions bot added documentation Improvements or additions to documentation api python PRs that change python files Root PythonDeps invocations PRs that change invocations backend PRs that change backend files services PRs that change app services frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Feb 27, 2024
@brandonrising brandonrising changed the base branch from main to next February 27, 2024 15:23
maryhipp
maryhipp reviewed Feb 27, 2024
View reviewed changes
invokeai/app/invocations/compel.py
).model
assert isinstance(ti_model, TextualInversionModelRaw)
ti_list.append((name, ti_model))
loaded_model = context.models.load(key=name).model
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename name to key on line 193 just to make it clear that this is no longer using the embedding name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryhipp maryhipp maryhipp left review comments

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant will be requested when the pull request is marked ready for review blessedcoolant is a code owner

@psychedelicious psychedelicious Awaiting requested review from psychedelicious psychedelicious will be requested when the pull request is marked ready for review psychedelicious is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername will be requested when the pull request is marked ready for review hipsterusername is a code owner

Assignees
No one assigned
Labels
api backend PRs that change backend files documentation Improvements or additions to documentation frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies invocations PRs that change invocations python PRs that change python files Root services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonrising @maryhipp