Add a 60 second timeout to pytests #5831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
blessedcoolant and
hipsterusername
as code owners
|
PR superseded by #5835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
There's a threading-related bug in the model install module that causes the
test_model_installtest to hang fairly frequently. This introduces a global 1 minute timeout on all the tests and a more stringent timeout on the model install and download queue tests.(I have isolated where the hang occurs and am debugging further)
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
The hangs in the model install test will still occur, but they will now timeout in minutes rather than hours.
Merge Plan
Merge when approved.
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?