Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Mask from ID Node + ColorField Component Improvements #6008

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

blessedcoolant
Copy link
Collaborator

@blessedcoolant blessedcoolant commented Mar 20, 2024

Summary

Adds a Mask from ID node that lets you drop in an ID Mask to the node and create a mask based on the color you pick from the ID Map.

The color is currently set to color field (but we need to add an Color Picker) to make it easier to pick the color or can just replace it with hex. Either way works. There's support for both.

opera_PE2C5D4DkC.mp4

Updated ColorField Component

  • Now also displays the hex code for the color value.
  • Fixed up the UI for the Color Picker in the Nodes not filling up the entire space.
opera_gG6TeanBQO.mp4

Merge Plan

Can't think of anything to not merge it.

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations labels Mar 20, 2024
@github-actions github-actions bot added the frontend PRs that change frontend files label Mar 20, 2024
@blessedcoolant blessedcoolant changed the title feat: Add Mask from ID Node feat: Add Mask from ID Node + ColorField Component Improvements Mar 20, 2024
@psychedelicious
Copy link
Collaborator

@blessedcoolant Did you see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color that skunkworx found? It has a dropper!

@blessedcoolant
Copy link
Collaborator Author

blessedcoolant commented Mar 21, 2024

@blessedcoolant Did you see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color that skunkworx found? It has a dropper!

Yep. Doesn't work. Even the example in the docs doesn't work for the eye dropper. At least not on Chrome. And the API is non-existent on Firefox.

@psychedelicious
Copy link
Collaborator

That's unfortunate. On macOS:

  • Chrome uses a custom picker with dropper.
  • FF uses the OS-provided picker, which also has a dropper.

@blessedcoolant
Copy link
Collaborator Author

blessedcoolant commented Mar 21, 2024

That's unfortunate. On macOS:

  • Chrome uses a custom picker with dropper.
  • FF uses the OS-provided picker, which also has a dropper.

Actually it works. Sorry, there was no feedback from the click so I thought it wasn't working. But clicking outside actually picks a color. However this is only on Chromium browsers on my end.

On Windows, Firefox uses this:

firefox_aSesiXf1iJ

@blessedcoolant blessedcoolant force-pushed the id-to-mask branch 2 times, most recently from 3d27142 to 042651c Compare March 21, 2024 21:31
@blessedcoolant blessedcoolant enabled auto-merge (rebase) March 22, 2024 00:45
@blessedcoolant blessedcoolant merged commit 4687739 into invoke-ai:main Mar 22, 2024
14 checks passed
@blessedcoolant blessedcoolant deleted the id-to-mask branch May 5, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants