-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up latent.py (code reorganization, no functional changes) #6491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just rename latents.py to denoise_latents.py then? Rest of it seems good. This file needed to be decoupled.
Good point. Renamed in 68ab579 |
…file. No functional changes.
68ab579
to
52c0c4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I'd simply suggest changing latent.py
to denoise_latents.py
in order to be consistent with the naming scheme.
[edit] I see blessedcoolant had the same suggestion; did that commit just go through as I was reviewing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the change to latents.py now. Approved.
The import path for SchedulerOutput in the invocation_api needs to be changed from invokeai.app.invocations.denoise_latents import SchedulerOutput to from invokeai.app.invocations.scheduler import SchedulerOutput |
Summary
I've started working towards a better tiled upscaling implementation. It is going to require some refactoring of
DenoiseLatentsInvocation
. As a first step, this PR splits up all of the invocations in latent.py into their own files. That file had become a bit of a dumping ground - it should be a bit more manageable to work with now.This PR just re-organizes the code. There should be no functional changes.
QA Instructions
I've done some light smoke testing. I'll do some more before merging. The main risk is that I missed a broken import, or some other copy-paste error.
Checklist