Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controlnet starters #6537

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update controlnet starters #6537

merged 2 commits into from
Jun 28, 2024

Conversation

hipsterusername
Copy link
Member

Summary

Updates the starter controlnets to the improved models released by Xinsir

QA Instructions

Can validate that the starter models are listed and install successfully.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files labels Jun 24, 2024
lstein
lstein approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

However, I've noticed that the descriptions and human readable names given in the starter_models.py module aren't being copied into the database during installation.

@psychedelicious psychedelicious enabled auto-merge (rebase) June 28, 2024 07:41
@psychedelicious psychedelicious merged commit 5df2a79 into main Jun 28, 2024
14 checks passed
@psychedelicious psychedelicious deleted the update-controlnet-starters branch June 28, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstein lstein lstein approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@RyanJDick RyanJDick Awaiting requested review from RyanJDick RyanJDick is a code owner

Assignees
No one assigned
Labels
backend PRs that change backend files python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hipsterusername @lstein @psychedelicious