fix(ui): reset page when search term changes #6569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
maryhipp
approved these changes
Jul 3, 2024
- For single image deletion, select the image in the same slot as the deleted image - For multiple image deletion, empty selection - On list images, if no images are currently selected, select the first image
|
fix(ui): revise image selection after deletion
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When changing the search term, we should reset the page (set offset to 0).
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1149513625321603162/1257795535482392727
QA Instructions
Without this PR, we expect that the search results will start on a page equal to the previously selected page, or the last possible page of the search results.
With this PR, we expect that the search results will start on the first page.
Merge Plan
n/a
Checklist