Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM bugfix] Put model install errors on the event bus #6578

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Jul 4, 2024

Summary

Model install errors were not being placed on the event bus, preventing the web interface's Model Install tab from reporting errors. This would cause the model install status to be shown as "pending" and never update.

This applies a small fix to the issue, and adds a new unit test for regressions.

Related Issues / Discussions

As far as I can see, nobody has reported this.

QA Instructions

  1. Launch the web interface
  2. Go to the model manager panel
  3. Click "Add Model" and URL or local path
  4. Enter a bad URL (e.g. one that doesn't point to a model)
  5. The model install queue should immediately show a new entry with status Failed

Merge Plan

Merge when approved.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files services PRs that change app services python-tests PRs that change python tests labels Jul 4, 2024
@psychedelicious
Copy link
Collaborator

Thanks, I've been wondering why the errors weren't showing up! I had only tested with civitai, but with the api tokens thing not working, I just assumed it was a civitai issue.

@lstein lstein merged commit 0fe92cd into main Jul 4, 2024
14 checks passed
@lstein lstein deleted the lstein/bugfix/reenable-download-access-tokens branch July 4, 2024 02:44
@lstein
Copy link
Collaborator Author

lstein commented Jul 4, 2024

Thanks, I've been wondering why the errors weren't showing up! I had only tested with civitai, but with the api tokens thing not working, I just assumed it was a civitai issue.

Yes, I thought it was a Civitai problem as well because wget wasn't working as it used to from the command line. However, this turned out to be an unrelated problem involving Civitai->Cloud Flair redirects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python PRs that change python files python-tests PRs that change python tests services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants