Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boards UI update and add support for private boards #6588

Merged
merged 22 commits into from
Jul 9, 2024
Merged

Conversation

chainchompa
Copy link
Contributor

@chainchompa chainchompa commented Jul 9, 2024

Summary

Update Boards UI in the gallery and adds support for creating and displaying private boards

Related Issues / Discussions

QA Instructions

Can view private boards by setting config.allowPrivateBoards to true

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added api python PRs that change python files services PRs that change app services frontend PRs that change frontend files labels Jul 9, 2024
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did a styling pass and fixed a few edge cases (see commit messages). Simplified a lot of the markup while retaining the same overall layout.

There are a number of things I'd like to iterate on but didn't get to.

  1. When the board name is long, it's hard to select the board without editing the name. Some ideas:
  • Make it edit on double click. I couldn't figure out how to programmatically start editing the <Editable /> component - maybe using the useEditableControls hook? Might need to be a custom component. Not sure I like this really anyways.
  • Use the example in the chakra docs for having a separate button that starts editing.
  • Use a modal to rename boards and remove the click-to-edit functionality.
  1. This UI is getting thicc:
    image
    Seems really chunky. Before the gallery changes, you could minimize it to just two rows - board name and the images/assets buttons. Now it's a minimum of 5 rows - 6 (!) if you have private boards. Feels like way too much. Most of the time, I don't care about any of the rows.

  2. When searching boards, we don't hide the uncategorized board. Maybe we should?

  3. When you add a board, it doesn't clear the search term. Unless you are lucky with your search term, the newly-created board doesn't show up and it seems like no board was added.

  4. Unrelated to this PR, but I was adding a lot of boards to test and then it was a pain to delete them one-by-one via the context menu.

  5. The image count starts cramping each row when the board name is long, so I removed the word "images". We could use a container query to conditionally render that extra word depending on the container's width.

I don't think these should be blockers for this PR.

@chainchompa chainchompa merged commit c90b554 into main Jul 9, 2024
14 checks passed
@chainchompa chainchompa deleted the boards-ui-update branch July 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api frontend PRs that change frontend files python PRs that change python files services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants