-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boards UI update and add support for private boards #6588
Conversation
invokeai/frontend/web/src/features/gallery/components/Boards/BoardsList/BoardsList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/gallery/components/Boards/BoardsList/BoardsList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/gallery/components/Boards/BoardsList/BoardsList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/gallery/components/Boards/BoardsList/BoardsList.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I did a styling pass and fixed a few edge cases (see commit messages). Simplified a lot of the markup while retaining the same overall layout.
There are a number of things I'd like to iterate on but didn't get to.
- When the board name is long, it's hard to select the board without editing the name. Some ideas:
- Make it edit on double click. I couldn't figure out how to programmatically start editing the
<Editable />
component - maybe using theuseEditableControls
hook? Might need to be a custom component. Not sure I like this really anyways. - Use the example in the chakra docs for having a separate button that starts editing.
- Use a modal to rename boards and remove the click-to-edit functionality.
-
This UI is getting thicc:
Seems really chunky. Before the gallery changes, you could minimize it to just two rows - board name and the images/assets buttons. Now it's a minimum of 5 rows - 6 (!) if you have private boards. Feels like way too much. Most of the time, I don't care about any of the rows. -
When searching boards, we don't hide the uncategorized board. Maybe we should?
-
When you add a board, it doesn't clear the search term. Unless you are lucky with your search term, the newly-created board doesn't show up and it seems like no board was added.
-
Unrelated to this PR, but I was adding a lot of boards to test and then it was a pain to delete them one-by-one via the context menu.
-
The image count starts cramping each row when the board name is long, so I removed the word "images". We could use a container query to conditionally render that extra word depending on the container's width.
I don't think these should be blockers for this PR.
Summary
Update Boards UI in the gallery and adds support for creating and displaying private boards
Related Issues / Discussions
QA Instructions
Can view private boards by setting config.allowPrivateBoards to true
Merge Plan
Checklist