Demote error log to warning for models treated as having size 0 #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanJDick
requested review from
lstein,
blessedcoolant,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Demote error log to warning for models treated as having size 0.
Related Issues / Discussions
Closes #6587
I looked into handling ESRGAN model sizes properly. They load a state_dict with a bit of an unusual nested-dict structure. Rather than figure out how to accurately calculate their size, we can just wait for #6556. ESRGAN model size handling should work properly when loaded through that pathway.
QA Instructions
Loaded an ESRGAN model, and confirmed that the warning log is at the warning level.
Merge Plan
No special instructions.
Checklist