Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): gallery followups #6601

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix(ui): gallery followups #6601

merged 3 commits into from
Jul 12, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Prevent cutoff of last board in the list when scrolling down to the bottom.
  • Fix handling of selected and auto-add boards when a board is archived or deleted.
  • Do not invalidate an image's query cache when it was deleted. This was causing spurious getImageDTO requests and console errors like [2024-07-12 10:46:50,049]::[InvokeAI]::ERROR --> Image record not found.

Related Issues / Discussions

QA Instructions

  • Board list should display correctly.
  • Should be able to generate/delete on archived boards (when they are visible in the list).
  • Delete a big image on windows and confirm it deletes correctly.

Merge Plan

Once we are sure the deletion issue is resolved we can do another release. May also want to get the intermediates count issue resolved first.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jul 12, 2024
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/gallery-followups branch from a7bad89 to 3477cb4 Compare July 12, 2024 04:19
@psychedelicious psychedelicious mentioned this pull request Jul 12, 2024
Closed
5 tasks
@psychedelicious psychedelicious merged commit fb1130c into main Jul 12, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/gallery-followups branch July 12, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Failed to delete image file
2 participants
@psychedelicious @hipsterusername