Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to disable lora patching optimization introduced by #6439 #6628

Closed

Conversation

leo9800
Copy link

@leo9800 leo9800 commented Jul 16, 2024

Summary

LoRA patching optimization introduced in PR #6439 may cause issue in some edge cases, which prevents InvokeAI to generate any reasonable image.

This patch add an configuration option to allow users to disable the change introduced in #6439 in case the issue occurs.

Related Issues / Discussions

QA Instructions

I tested this on my server (no GPU, running InvokeAI on an Intel Ice Lake SP CPU) and problem (mentioned in #6559) is addressed.

Since it is probably an edge case, (only 2 issues are found possibly related to it) it may not always be reproducible.

Merge Plan

N/A (This patch won't touch anything big, e.g. db schema, etc)

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations services PRs that change app services labels Jul 16, 2024
@leo9800 leo9800 marked this pull request as ready for review July 16, 2024 08:10
@lstein
Copy link
Collaborator

lstein commented Jul 17, 2024

It looks like the issue appears specifically when rendering on CPU, is that correct? If this is the case, then we should just be disabling the LoRA optimization whenever the rendering device is set for CPU.

Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug that appears consistently when rendering on the CPU device, so a user config change is overkill. See PR #6631 for a simpler solution.

@lstein
Copy link
Collaborator

lstein commented Jul 18, 2024

I'm very sorry, but this is superseded by #6631. The latter is preferred because it does not require the user to make a configuration file change. Please continue to contribute bug reports and fixes!

@lstein lstein closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invocations PRs that change invocations python PRs that change python files services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants