Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular backend - add FreeU #6641

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

StAlKeR7779
Copy link
Contributor

Summary

FreeU code from #6577.
Also fix issue with sometimes slightly different output.

Related Issues / Discussions

#6606
https://invokeai.notion.site/Modular-Stable-Diffusion-Backend-Design-Document-e8952daab5d5472faecdc4a72d377b0d

QA Instructions

Run with and without set USE_MODULAR_DENOISE environment.

Merge Plan

Nope.
If you think that there should be some kind of tests - feel free to add.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files labels Jul 21, 2024
Copy link
Collaborator

@RyanJDick RyanJDick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

invokeai/backend/stable_diffusion/extensions/freeu.py Outdated Show resolved Hide resolved
invokeai/backend/stable_diffusion/extensions/freeu.py Outdated Show resolved Hide resolved
invokeai/backend/stable_diffusion/extensions/freeu.py Outdated Show resolved Hide resolved
invokeai/backend/stable_diffusion/diffusion_backend.py Outdated Show resolved Hide resolved
Co-Authored-By: Ryan Dick <[email protected]>
RyanJDick added a commit that referenced this pull request Jul 23, 2024
## Summary

Rescale CFG code from #6577.

## Related Issues / Discussions

#6606 

https://invokeai.notion.site/Modular-Stable-Diffusion-Backend-Design-Document-e8952daab5d5472faecdc4a72d377b0d

## QA Instructions

Run with and without set `USE_MODULAR_DENOISE` environment.
~~Note: for some reasons there slightly different output from run to
run, but I able sometimes to get same output on main and this branch.~~
Fix presented in #6641.

## Merge Plan

~~Nope.~~ Merge #6641 firstly, to be able see output difference
properly.
If you think that there should be some kind of tests - feel free to add.

## Checklist

- [x] _The PR has a short but descriptive title, suitable for a
changelog_
- [ ] _Tests added / updated (if applicable)_
- [ ] _Documentation added / updated (if applicable)_
@RyanJDick RyanJDick enabled auto-merge July 23, 2024 13:57
@RyanJDick RyanJDick merged commit 7b8e25f into invoke-ai:main Jul 23, 2024
14 checks passed
RyanJDick added a commit that referenced this pull request Jul 23, 2024
## Summary

ControlNet code from #6577.

## Related Issues / Discussions

#6606

https://invokeai.notion.site/Modular-Stable-Diffusion-Backend-Design-Document-e8952daab5d5472faecdc4a72d377b0d

## QA Instructions

Run with and without set `USE_MODULAR_DENOISE` environment.

## Merge Plan

Merge #6641 firstly, to be able see output difference properly.
If you think that there should be some kind of tests - feel free to add.

## Checklist

- [x] _The PR has a short but descriptive title, suitable for a
changelog_
- [ ] _Tests added / updated (if applicable)_
- [ ] _Documentation added / updated (if applicable)_
@StAlKeR7779 StAlKeR7779 deleted the stalker7779/modular_freeu branch July 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants