feat(ui): add upsells for pro edition to settings menu #6650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
hipsterusername
approved these changes
Jul 23, 2024
maryhipp
force-pushed
the
maryhipp/add-upsell-to-settings
branch
from
0cfd1f2
to
844074d
Compare
Comment on lines
+15
to
+21
| <Icon | ||
| as={PiArrowUpBold} | ||
| sx={{ | ||
| mt: '2px', | ||
| fill: 'invokeYellow.500', | ||
| }} | ||
| /> |
There was a problem hiding this comment.
Please use style props instead of sx. Instead of using margin, we can use a Flex with alignItems/justifyContent center.
| const { t } = useTranslation(); | ||
|
|
||
| return ( | ||
| <Tooltip label={t('upsell.professionalUpsell')} placement="right" zIndex={2}> |
There was a problem hiding this comment.
Manually specifying zIndex can cause issues, especially on the workflows tab where reactflow does stuff to zIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds menu items to settings menu for pro upsells
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist