feat(ui): more gallery UX updates #6652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
changed the title
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
added 8 commits
July 23, 2024 20:15
…egorized out of board list, allow collapsible board list if private enabled
…is entered, clear search when view is toggled off
…de/view boards button for toggle
maryhipp
force-pushed
the
maryhipp/gallery-ui-updates-2
branch
from
3ed67fb
to
c6a7828
Compare
When the totals were high enough, the image looked really off. Also fixed some inconsistent padding.
the gap isn't handled smoothly, there's always a jump. cannot use gap in the collapsible's container
…rd search toggle state You can't even see the icon, no point in changing it. Blue = active/open, Grey = closed.
Use this to enforce singleton components and hooks.
It was possible to clear the search term while a debounced setSearchTerm is still pending. This resulted in the gallery getting out of sync w/ the search term. To fix this, we need to lift the state up a bit and cancel any pending debounced setSearchTerm calls when closing the search or clearing the search term box.
psychedelicious
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist