Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple upscale bugfixes #6655

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Simple upscale bugfixes #6655

merged 4 commits into from
Jul 23, 2024

Conversation

chainchompa
Copy link
Contributor

Summary

  • put upscaled image on correct board
  • only check for simpleUpscaleModel when displaying warning
  • remove useIsAllowedToUpscale logic

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jul 23, 2024
@chainchompa chainchompa marked this pull request as ready for review July 23, 2024 20:48
psychedelicious
psychedelicious approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll fix the other issues.

@psychedelicious psychedelicious merged commit 54aef49 into main Jul 23, 2024
27 checks passed
@psychedelicious psychedelicious deleted the chainchompa/simple-upscale-fixes branch July 23, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chainchompa @psychedelicious