-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): upscaling & ad-hoc post-processing misc #6658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
July 23, 2024 21:52
github-actions
bot
added
python
PRs that change python files
invocations
PRs that change invocations
frontend
PRs that change frontend files
labels
Jul 23, 2024
hipsterusername
approved these changes
Jul 23, 2024
`spandrel_image_to_image` now just runs the model with no changes. `spandrel_image_to_image_autoscale` runs the model repeatedly until the desired scale is reached. previously, `spandrel_image_to_image` did this.
psychedelicious
force-pushed
the
psyche/fix/ad-hoc-upscale
branch
from
July 23, 2024 22:09
f471bfa
to
f9397c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
PRs that change frontend files
invocations
PRs that change invocations
python
PRs that change python files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Round of updates & fixes for upscaling tab and ad-hoc post-processing (previously called ad-hoc upscaling). Mostly fixing verbiage and splitting off the post-processing UI from the upscaling UI.
One other notable change:
feat(nodes): split spandrel node
spandrel_image_to_image
now just runs the model with no changes.spandrel_image_to_image_autoscale
runs the model repeatedly until the desired scale is reached. previously,spandrel_image_to_image
did this.The ad-hoc post-processing feature uses
spandrel_image_to_image
. It processes the image using the model without any special handling. The upscaling tab usesspandrel_image_to_image_autoscale
- its behaviour is unchanged.Related Issues / Discussions
n/a
QA Instructions
The ad-hoc upscale popover UI is updated with its new identity as a post-processing popover.
post.popover.mov
Because we now refer to spandrel models as "image to image", "upscale" and "post-processing" models in different places, the starter models search is updated to understand these search terms.
starter.models.search.mov
All generation functionality - both upscaling tab and post-processing popover - should be unchanged.
Merge Plan
n/a
Checklist