Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): upscaling & ad-hoc post-processing misc #6658

Merged
merged 14 commits into from
Jul 23, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

Round of updates & fixes for upscaling tab and ad-hoc post-processing (previously called ad-hoc upscaling). Mostly fixing verbiage and splitting off the post-processing UI from the upscaling UI.

One other notable change:

  • feat(nodes): split spandrel node

    spandrel_image_to_image now just runs the model with no changes.

    spandrel_image_to_image_autoscale runs the model repeatedly until the desired scale is reached. previously, spandrel_image_to_image did this.

The ad-hoc post-processing feature uses spandrel_image_to_image. It processes the image using the model without any special handling. The upscaling tab uses spandrel_image_to_image_autoscale - its behaviour is unchanged.

Related Issues / Discussions

n/a

QA Instructions

The ad-hoc upscale popover UI is updated with its new identity as a post-processing popover.

post.popover.mov

Because we now refer to spandrel models as "image to image", "upscale" and "post-processing" models in different places, the starter models search is updated to understand these search terms.

starter.models.search.mov

All generation functionality - both upscaling tab and post-processing popover - should be unchanged.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations frontend PRs that change frontend files labels Jul 23, 2024
@psychedelicious psychedelicious enabled auto-merge (rebase) July 23, 2024 22:10
@psychedelicious psychedelicious merged commit b99a53e into main Jul 23, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/ad-hoc-upscale branch July 23, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants