Fix gradient mask values range #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StAlKeR7779
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
blessedcoolant
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gradient mask node outputs mask tensor with values in range [-1, 1], which unexpected range for mask.
It handled in denoise node the way it translates to [0, 2] mask, which looks even more wrongly)
From discussion with @dunkeroni I understand him as he thought that negative values will be treated same as 0, so clamping values not change intended node logic.
Related Issues / Discussions
#6643
QA Instructions
-
Merge Plan
-
Checklist